Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add toyaml/fromyaml (#1911) #2036

Merged
merged 1 commit into from
Jan 10, 2020
Merged

add toyaml/fromyaml (#1911) #2036

merged 1 commit into from
Jan 10, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Jan 8, 2020

Fixes #1911

Also add those values to the list of banned project names.

@cla-bot cla-bot bot added the cla:yes label Jan 8, 2020
drewbanin
drewbanin approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, ship it!

@beckjake beckjake merged commit b11aab5 into dev/barbara-gittings Jan 10, 2020
@beckjake beckjake deleted the feature/toyaml-fromyaml branch January 10, 2020 19:20
@beckjake beckjake mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @drewbanin