-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for a file path that can't be cleaned #2060
Conversation
@drewbanin I think these tests are failing because someone internal has to kick them off |
Thanks for making this PR @emilieschario! I just kicked off the tests here. This is super minor, but what's your rationale behind not indenting the log line that you added here? And what would you think about updating this line to be even more apparent with something like:
Let me know what you think! |
On the not indenting piece, it was being it was hard to anticipate the length, so it could be a short name like
But I love love love the error message! I'm going to update now so that you can kick off tests again, if you're still around |
Updated @drewbanin! |
Thanks @emilieschario! This LGTM, but I have terrible news: your new change has a line that's longer than 80 characters, so it won't pass our code formatting CI check. Can you try changing this line:
to look like:
This will fix the pep8 error that might show up in Circle momentarily :) |
Thanks for your patience here @drewbanin! Updated! |
np! Thanks for that - just kicked off the tests again and will get this merge when they pass :) |
hey @emilieschario - this code is definitely read to roll, but in testing this feature, I did notice a big problem! Check out this code (unrelated to your PR): https://github.com/fishtown-analytics/dbt/pull/2060/files#diff-0927dc49a0a3b3ad824b956c8f0abb3fR21-R26 On line 24 here, we call:
The problem is that we're not calling the
These list elements are pointers to the If you're interested in fixing that issue in the scope of this PR, I think that would be a really good and helpful change. If not, we can totally queue up a second ticket to address it. Let me know! |
woah. so why didn't my file get cleaned before if it wasn't because it was being deemed a file path? how did I come to this conclusion? 😕 I think I got it. Thanks for giving me the chance to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emilieschario - looks great! I'm kicking off the tests one last time, then will merge this when they pass :)
Thanks for the opportunity @drewbanin! |
Closes #2059
In a case where your
dbt_project.yml
file has:when you run
dbt clean
you'll see a message that looks like:Because it doesn't tell you you did something wrong, you may not notice that the
model/*
file wasn't cleaned (rightfully so!). This MR proposes that the messaging be:No functional differences, just more details.