Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore alternative resource types when reading partial parse cache (#2064) #2065

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

beckjake
Copy link
Contributor

Fix #2064

When we use a parser to load the manifest from the cache, skip any nodes that don't match the parser's node type. Sources, Docs, Patches, and Macros are never skipped.

@cla-bot cla-bot bot added the cla:yes label Jan 22, 2020
@beckjake beckjake requested a review from drewbanin January 22, 2020 20:05
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it :)

@beckjake beckjake merged commit 0b8f3bc into dev/0.15.2 Jan 24, 2020
@beckjake beckjake deleted the fix/ignore-alternative-resource-types branch January 24, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial parsing: duplicate resource error (redux)
2 participants