Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use threadpools for filling the cache and listing schemas (#2127) #2157

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 25, 2020

(maybe) resolves #2127

Description

Parallelize the parts of dbt that fill the cache and list schemas (by database), using concurrent.futures.ThreadPoolExecutor.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Feb 25, 2020
@beckjake beckjake force-pushed the feature/threadpool-startup branch from 3c765c8 to ed38cbb Compare February 25, 2020 18:43
@beckjake beckjake marked this pull request as ready for review February 26, 2020 15:24
@beckjake beckjake requested a review from drewbanin February 26, 2020 15:24
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! Works great in practice, let's go ahead and ship it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate schema discovery queries that happen at startup
2 participants