Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commit messages by using the stack properly (#2073) #2238

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2073

Description

Actually use the stack attribute on caught exceptions, change some .node settings to use the stack.

The output of a model (x) that calls a macro (hello) with an invalid argument looks like this:

$ dbt compile
Running with dbt=0.17.0-a1
Encountered an error:
Compilation Error in model x (models/x.sql)
  macro 'dbt_macro__hello' takes no keyword argument 'invalid'

  > in macro hello (macros/hello.sql)
  > called by model x (models/x.sql)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 24, 2020
@beckjake beckjake force-pushed the fix/macro-kwarg-error-add-file branch from 06b74d6 to 427f3bf Compare March 24, 2020 21:13
@beckjake beckjake requested a review from drewbanin March 24, 2020 21:15
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

@beckjake beckjake merged commit 0188d03 into dev/octavius-catto Mar 25, 2020
@beckjake beckjake deleted the fix/macro-kwarg-error-add-file branch March 25, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'No keyword argument' macro error does not report location of bad call
2 participants