Add db_groups and autocreate flags to Redshift config

[kyleabeauchamp]

Resolves #1995

Description

This PR adds the db_groups and autocreate flags in redshift configurations.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @kyleabeauchamp

[kyleabeauchamp]

I believe I signed the CLA just prior to opening this PR, so perhaps it hasn't processed yet.

[beckjake]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[beckjake]

@kyleabeauchamp Thanks for your contribution! The cla-bot process has a manual step that we have to update - should be set now. I like this PR it looks great! Just a few things:

• A couple changelog updates
• Can you please add a unit test to make sure the parameters keep getting passed along properly in the future? There should be some relevant tests in test/unit/test_redshift_adapter.py.
• It looks like flake8 is unhappy with some indentation:

plugins/redshift/dbt/adapters/redshift/connections.py:103:17: E123 closing bracket does not match indentation of opening bracket's line

[beckjake]

Suggested change

	- Added support for `db_groups` and `autocreate` flags in Redshift configurations. ([#1995](https://github.com/fishtown-analytics/dbt/issues/1995))
	- Added support for `db_groups` and `autocreate` flags in Redshift configurations. ([#1995](https://github.com/fishtown-analytics/dbt/issues/1995)([#2262](https://github.com/fishtown-analytics/dbt/pull/2262))

Please add a link to this PR to the CHANGELOG

Also, please add an entry to Contributors with your username.

[kyleabeauchamp]

I've fixed the changelog and lint, will take a look at tests this evening.

[kyleabeauchamp]

OK I've added a very simple addition to one of the unit tests, let me know if there are any other good tests that can be modified. It seems like the unit tests mostly mock out the boto interfaces, so it's not clear if there's any simple way to test the full end-to-end.

[beckjake]

@kyleabeauchamp Ok, I guess that's fair - we don't have any tests that mock out the boto get_cluster_credentials call and make sure that dbt passed values in. The existing test is probably sufficient.

The only way to really test this end-to-end is going to be to make an integration test out of it, which sounds like a lot.

One more thing - can you rebase and squash some of this against dev/octavius-catto? It seems like you've picked up merge commits going back as far as 0.12.1(!) and ideally this would just be one or two commits. Once you do that I'll kick off the full test suite and then we can merge this. Thanks!

[drewbanin]

I can manually QA this if that would be helpful, and @beckjake we can totally set up integration test creds against our redshift instance if desired!

[beckjake]

@drewbanin that would be awesome.

I think credentials to test this would be good too - should that be a seprate PR? I think a lot of it will be fiddly credentials/env var things in CI, no need for contributors to be stuck in the middle of that, right?

[drewbanin]

Yeah - we can do that in a separate PR for sure. I'll ping you offline with creds in 1pass

[kyleabeauchamp]

I did a git rebase (git rebase -i dev/octavius-catto) and now things look worse.

[kyleabeauchamp]

Ah, I rebased to the fork, not the upstream...

[kyleabeauchamp]

OK I think I've rebased things appropriately.

[beckjake]

Looks great! I've rebased everything and kicked off tests, I'll get some integration tests open for this once it merges. Thanks for your contribution!

[drewbanin]

nice one @kyleabeauchamp! :D