Do not require a profile in "dbt deps" (#2231) #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead Add tests
- remove import cycle - works even if adapter class has been loaded but adapter object has not been registered
beckjake
force-pushed
the
fix/deps-no-profile-required
branch
from
daa2e07
to
f0a4810
Compare
drewbanin
reviewed
Apr 2, 2020
core/dbt/config/runtime.py
Outdated
| @@ -171,3 +173,172 @@ def get_metadata(self) -> ManifestMetadata: | |||
| project_id=self.hashed_name(), | |||
| adapter_type=self.credentials.type | |||
| ) | |||
|
|
|||
|
|
|||
| class PoisonedCredentials(Credentials): | |||
There was a problem hiding this comment.
Can we s/Poisoned/Unset here? I'm also open to:
- InvalidConfig
- NotPresentConfig
- MissingConfig
There was a problem hiding this comment.
Sure, I don't care at all what we call it
I don't think a user could. I think a code change inside dbt could inadvertently do so, and I'm interested in that not happening silently. |
drewbanin
approved these changes
Apr 2, 2020
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2231
Description
In "dbt deps", if a profile cannot be found/loaded, use invalid values instead. The generated rendering context for projects in this case will still contain
target, but it will be empty.This works by overriding all the profile-ish elements of
RuntimeConfigif a real profile can't be found. If a real profile is found,depswill use a fullRuntimeConfiglike previously.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.