-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake column comments #2321
Changes from all commits
b98a4d8
eb3ed57
8de3235
ea82d8f
d9862af
74df1a1
78110e1
06ffb6d
f843e65
1448d0b
0fdff04
5cabafc
f58bc49
bd2d1f7
ffaaacc
b774702
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{% macro get_relation_comment(persist_docs, model) %} | ||
|
||
{%- if persist_docs is not mapping -%} | ||
{{ exceptions.raise_compiler_error("Invalid value provided for 'persist_docs'. Expected dict but got value: " ~ raw_persist_docs) }} | ||
{{ exceptions.raise_compiler_error("Invalid value provided for 'persist_docs'. Expected dict but got value: " ~ persist_docs) }} | ||
{% endif %} | ||
|
||
{% if persist_docs.get('relation', false) %} | ||
|
@@ -13,8 +13,8 @@ | |
{% endmacro %} | ||
|
||
|
||
{# copy+pasted from the snowflake PR - delete this on merge #} | ||
{% macro get_relation_column_comments(persist_docs, model) %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the exception below would return an error, because the macro argument is named As it is, I haven't been able to actually get this exception/error. It's preempted by a parsing error, now that model + project configs have tighter type enforcement:
All the same, the argument should be named There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. resolved, I stuck with |
||
|
||
{%- if persist_docs is not mapping -%} | ||
{{ exceptions.raise_compiler_error("Invalid value provided for 'persist_docs'. Expected dict but got value: " ~ persist_docs) }} | ||
{% endif %} | ||
|
@@ -26,3 +26,4 @@ | |
{% endif %} | ||
|
||
{% endmacro %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same as my above comment applies here - I think these two are the only overlap! |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{{ | ||
config ({ | ||
"materialized" : 'incremental', | ||
"persist_docs" : { "relation": true, "columns": true, "schema": true } | ||
}) | ||
}} | ||
|
||
select 1 as column1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
models: | ||
- name: view_test | ||
description: > | ||
View - "money" aka $$$$$ | ||
columns: | ||
- name: column1 | ||
description: test 1 - abcd "" $$$ '' | ||
|
||
- name: incremental_test | ||
description: > | ||
Incremental - "money" aka $$$$$ | ||
columns: | ||
- name: column1 | ||
description: test 1 - abcd "" $$$ '' | ||
|
||
- name: table_test | ||
description: > | ||
Table - "money" aka $$$$$ | ||
columns: | ||
- name: column1 | ||
description: test 1 - abcd "" $$$ '' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{{ | ||
config ({ | ||
"materialized" : 'table', | ||
"persist_docs" : { "relation": true, "columns": true, "schema": true } | ||
}) | ||
}} | ||
|
||
select 1 as column1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{{ | ||
config ({ | ||
"persist_docs" : { "relation": true, "columns": true, "schema": true } | ||
}) | ||
}} | ||
|
||
select 1 as column1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snowflakeseitz Can you remove these, or the ones from the bottom of the file and the comment on the other ones? I merged the redshift/postgres PR and I must have messed it up, git didn't detect the duplicate changes as I expected it to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I just rebase to your changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I think you'll have to remove them during the rebase anyway.