Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include_policy vs. quote_policy bug in BigQueryRelation (#2188) #2325

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2188

Description

The BigQuery information schema previously used its quote policy as the basis
for a new include policy, rather than its include policy. This PR corrects that mistake.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 14, 2020
@beckjake beckjake requested a review from drewbanin April 14, 2020 20:38
The BigQuery information schema previously used its quote policy as the basis
for a new include policy, rather than its include policy.
@beckjake beckjake force-pushed the fix/bigquery-include-vs-quote-policy branch from 126fb47 to 644e3e8 Compare April 14, 2020 20:43
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckjake beckjake merged commit 51278c0 into dev/octavius-catto Apr 15, 2020
@beckjake beckjake deleted the fix/bigquery-include-vs-quote-policy branch April 15, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include_policy vs. quote_policy in BigQueryRelation
2 participants