Expose Snowflake query id in case of an exception raised by connector #2358
Conversation
…ctor * Allows to search for the query id inside the Snowflake query history * Allows for better communication with snowflake support through query ids
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @ChristianKohlberg |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
@ChristianKohlberg Thanks for your contribution, this looks great to me!
A quick question about snowflake - should we add special handling to the except Exception as e block that checks if it's a snowflake.connector.errors.Error and logs sfqid there, too? There are other kinds of snowflake errors, they apparently all have an sfqid attribute that can be None.
|
hey @ChristianKohlberg are you able to make the changes Jake requested? We'd love to ship this in the next dbt release if we can, so it would be great to get this PR merged by the end of the week :) |
|
Sorry for the low responsiveness. Will finish it up tonight and include the feedback from Jake. Many thanks for the patience in the meantime! |
Co-authored-by: Jacob Beck <beckjake@users.noreply.github.com>
|
@beckjake hope that this is now solved as anticipated. Once again sorry for the delay! |
|
Thanks for your contribution @ChristianKohlberg! We'll squeeze this into 0.17.0. |
resolves #2201
Description
This PR accomplishes:
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.