Add a special as_text filter to the native env (#2384) #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the value as a string no matter what.
Use like "{{ 1991 | as_text }}" -> "1991"
Also, moved the weird special quoting handling logic out and instead avoid calling the renderer on column_name arguments
beckjake
force-pushed
the
fix/bigquery-numbery-datasets
branch
from
fc0e978
to
0961bdb
Compare
drewbanin
approved these changes
May 4, 2020
core/dbt/clients/jinja.py
Outdated
| return env_cls(**args) | ||
| env = env_cls(**args) | ||
| if native: | ||
| env.filters['as_text'] = TextMarker |
There was a problem hiding this comment.
Sure! I think in the else case we actually want to set it to str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2384
Description
Add a special as_text filter to the native env that tells dbt to render the value as a string no matter what.
Use like
dataset: "{{ 1991 | as_text }}"->dataset: "1991"Also, I moved the weird special quoting handling logic out and instead avoid calling the renderer on column_name arguments entirely. Much better than doing weird things with quotes!
I added some very basic unit tests that should exercise this behavior.
I don't love this fix, but I think it's satisfactory and has the benefit of being really, really simple. There's just so little that can go horribly wrong!
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.