Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2440 to 0.17 #2442

Merged
merged 1 commit into from
May 13, 2020
Merged

Backport #2440 to 0.17 #2442

merged 1 commit into from
May 13, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2439 again

Description

See #2440

I left the changelog entry the same, it seemed like a silly merge conflict to create.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Also remove unused (and confusing/misleading) test data
@beckjake beckjake requested a review from drewbanin May 13, 2020 14:45
@cla-bot cla-bot bot added the cla:yes label May 13, 2020
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@beckjake beckjake merged commit 1de892b into dev/octavius-catto May 13, 2020
@beckjake
Copy link
Contributor Author

Merging before the tests finish - we actually already ran the tests against this exact commit already.

@beckjake beckjake deleted the fix/empty-persist-docs branch May 13, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants