Fix ENTRYPOINT to use 'dbt' #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just rebased it against the bugfix branch, updated the CHANGELOG and removed the Dockerfile changes @beckjake |
|
I think you accidentally pulled in some tests from |
|
and oops I included files I didn't mean to include |
dmateusp
force-pushed
the
dmateusp/fix_docker_entrypoints
branch
from
bd601fd
to
832d43e
Compare
|
Should be good now! |
beckjake
suggested changes
May 20, 2020
There was a problem hiding this comment.
Sorry, one last thing - can you also add a new Contributors: list to the changelog for this upcoming release that includes yourself? If you look further down the changelog you'll see it in the previous release, it's just your username and links to PRs. That way we can make sure we include you in the release notes!
|
Added! Although the change is so small it feels undeserved 😆 |
beckjake
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2470
This is a copy of #2471 targeting
dev/octavius-cattoafter @beckjake pointed out it is a bugfixDescription
Change the entrypoint to be able to pass arguments and use DBT as it is used outside the container
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.