Fix more jinja quoting sadness #2599
Conversation
…g, return the original
beckjake
force-pushed
the
fix/more-jinja-quoting-sadness
branch
from
bb31204
to
d374ef9
Compare
| ('''foo: "{{ true }}"''', True), | ||
| ('''foo: "{{ 'true' }}"''', 'true'), | ||
| ('''foo: "'{{ true }}'"''', "'True'"), | ||
| ('''foo: "{{ true | as_text }}"''', "True"), # true -> boolean True -> text -> str(True) -> 'True' |
There was a problem hiding this comment.
this one is surprising, but i guess that's what we should expect if true == True!
There was a problem hiding this comment.
I put that comment there because my initial reaction to this behavior was that it just had to be wrong 😆
| ('''foo: "{{ a_str ~ 100 }}"''', 100100), | ||
| ('''foo: "{{ a_int ~ 100 }}"''', 100100), | ||
| ('''foo: "{{ a_str }}{{ a_str }}"''', 100100), | ||
| ('''foo: "{{ a_int }}{{ a_int }}"''', 100100), |
There was a problem hiding this comment.
can you add one more test here for:
'''foo: "'{{ a_int }}{{ a_int }}'"'''
I would expect to see "100100" (as a string) but it's worth 1) double checking and 2) adding the test for it
There was a problem hiding this comment.
This actually ends up as the string '100100' (including quotes) - it's similar to the '''foo: "'{{ 1 }}'"''' test case.
There was a problem hiding this comment.
I am so sorry, I got the example wrong. You're right - I'd expect to see the single quotes in here too! '100100' is indeed what this should render out to
resolves #2597
Description
Per Drew's suggestion, if the input to
ast.literal_evalis a str and the output is a str, just return the initial value. I added some tests for the interaction of the native renderer with yaml to make sure they make sense.As usual, we are kind of caught in a corner with
yaml+jinja+ast.literal_evaltogether, and their slightly different interpretations of rendering. Note the irritating corner cases around differences betweentrueandTrueand1: Getting an unquoted string value of1still requiresas_text, but you can get atrueorTrueout without it (frequently this requires some unintuitive formulations).Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.