Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redshift catalog with custom schemas #2654

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2653

Description

Redshift now iterates over the schemas it's given properly, like postgres does, so all models that exist should get a catalog entry again!

I modified the existing test case to add a cross-schema model. Casing was a pain as usual, but it all appears good to me locally.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 28, 2020
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! docs site looks good locally

@beckjake beckjake merged commit 97f61a9 into dev/0.17.2 Jul 29, 2020
@beckjake beckjake deleted the fix/redshift-schema-override-catalog branch July 29, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants