Fix: require keyring on snowflake #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
approved these changes
Sep 24, 2020
drewbanin
reviewed
Sep 25, 2020
plugins/snowflake/setup.py
Outdated
| @@ -48,6 +48,7 @@ | |||
| install_requires=[ | |||
| 'dbt-core=={}'.format(package_version), | |||
| 'snowflake-connector-python==2.2.10', | |||
| 'snowflake-connector-python[secure-local-storage]', | |||
There was a problem hiding this comment.
I think the line above can just read
snowflake-connector-python[secure-local-storage]==2.2.10
I think these two things might be equivalent, but it might make sense to combine them here
drewbanin
approved these changes
Sep 25, 2020
|
Note there are other requirements for Snowflake MFA caching to work with Python connector, listed here: Python Connector for Snowflake version 2.3.7 (or later). Add this line to your Snowflake profile in profiles.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2779
Description
dbt-snowflake:snowflake-connector-python[secure-local-storage], which is really justkeyringAlternatives
We could put
snowflake-connector-python[secure-local-storage]underextras_requireinstead ofinstall_requires, since it's only really needed for external-browser auth. I opted for the more aggressive approach since:keyringinsnowflake-connector-pythonis quite permissiveI don't really know what I'm doing, though, when it comes to python deps!
Checklist
I have run this code in development and it appears to resolve the stated issueThis PR includes tests, or tests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.