Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the filtering for external tables in the Redshift get_columns_in_relation macro #2855

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Fix the filtering for external tables in the Redshift get_columns_in_relation macro #2855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
857bebe
Pushes the table_schema = '{{ relation.schema }}' clause down into th…
brangisom Oct 27, 2020
2a5d090
Pushes the `table_schema = '{{ relation.schema }}'` filter into the `…
brangisom Oct 27, 2020
ee2181b
Merge branch 'brangisom/spectrum-filter-fix' of github.com:brangisom/…
brangisom Oct 27, 2020
eb34c0e
Add stuff to changelog per checklist
brangisom Oct 27, 2020
348a2f9
Move a CHANGELOG entry
brangisom Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@

### Fixes
- Respect --project-dir in dbt clean command ([#2840](https://github.com/fishtown-analytics/dbt/issues/2840), [#2841](https://github.com/fishtown-analytics/dbt/pull/2841))
- Fix Redshift adapter `get_columns_in_relation` macro to push schema filter down to the `svv_external_columns` view ([#2855](https://github.com/fishtown-analytics/dbt/issues/2854))

Contributors:
- [@feluelle](https://github.com/feluelle) ([#2841](https://github.com/fishtown-analytics/dbt/pull/2841))
- [ran-eh](https://github.com/ran-eh) [#2596](https://github.com/fishtown-analytics/dbt/pull/2596)
- [@hochoy](https://github.com/hochoy) [#2851](https://github.com/fishtown-analytics/dbt/pull/2851)
- [@brangisom](https://github.com/brangisom) [#2855](https://github.com/fishtown-analytics/dbt/pull/2855)

## dbt 0.19.0b1 (October 21, 2020)

Expand Down
3 changes: 2 additions & 1 deletion plugins/redshift/dbt/include/redshift/macros/adapters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@
from
pg_catalog.svv_external_columns
where
tablename = '{{ relation.identifier }}'
schemaname = '{{ relation.schema }}'
and tablename = '{{ relation.identifier }}'

),

Expand Down