Make generated CTE test names lowercase to match style guide #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
reviewed
Jan 25, 2021
There was a problem hiding this comment.
Thanks for this @NiallRees! Just a comment about the changelog, then this is good to go.
| @@ -298,7 +298,7 @@ def filter_null_values(input: Dict[K_T, Optional[V_T]]) -> Dict[K_T, V_T]: | |||
|
|
|||
|
|
|||
| def add_ephemeral_model_prefix(s: str) -> str: | |||
| return '__dbt__CTE__{}'.format(s) | |||
| return '__dbt__cte__{}'.format(s) | |||
There was a problem hiding this comment.
For clarity, this method is no longer used, since #2712 swapped it out in favor of adapter.add_ephemeral_prefix.
| @@ -246,7 +246,7 @@ def _inject_ctes_into_sql(self, sql: str, ctes: List[InjectedCTE]) -> str: | |||
| return str(parsed) | |||
|
|
|||
| def _get_dbt_test_name(self) -> str: | |||
| return 'dbt__CTE__INTERNAL_test' | |||
| return 'dbt__cte__internal_test' | |||
There was a problem hiding this comment.
This should probably not be hard-coded within the compiler, and should instead do something like adapter.add_ephemeral_prefix('internal_test'), but that's a problem for another day. We're planning to clean up some inconsistencies around data tests for the v0.20.0 release, anyway.
There was a problem hiding this comment.
That would be nice to see 🙂
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3027
Description
Auto-generated dbt test CTE's have lowercase names to comply with dbt coding conventions. Makes SQLFluff happy which has to lint post-templated SQL. See #3027 for more
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.