Hard code dispatch namespaces for fivetran_utils? #3403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up from #3363
The
_get_utils_namespaces()
macro infivetran_utils
(source) works just slightly differently from the other get-namespace macros: It includesdbt_utils
, alongside itself, in the list of default packages to search in. So folks with Fivetran packages installed might see this error upon upgrading to 0.19.2 / 0.20.0:The most straightforward fix for this is just to set this variable in their project, and everything will work as anticipated:
This is closer to the syntax that users will need to have going forward:
At the same time, I want to take backwards compatibility really seriously, since this is otherwise a breaking change in a patch release. So this PR would shamelessly hard code backwards compatibility for that specific behavior.
I don't much like this:
dbt_utils
isn't actually a dependency offivetran_utils
, so it's conceivable that this might raise an error ifdbt_utils
isn't installed alongside it. That's true parity with current behavior, though.I could really go either way on this one!