Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextless macros #352

Closed
wants to merge 18 commits into from
Closed

contextless macros #352

wants to merge 18 commits into from

Conversation

cmcarthur
Copy link
Member

WIP

cmcarthur
cmcarthur commented Mar 27, 2017
View reviewed changes
test/unit/test_parser.py
macro_file_contents=macro_file_contents,
root_path=get_os_path('/usr/src/app'),
package_name='root')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drewbanin fyi

@drewbanin drewbanin force-pushed the contextless-macros branch from ae792eb to ace4b49 Compare March 28, 2017 02:47
cmcarthur
cmcarthur commented Mar 28, 2017
View reviewed changes
dbt/clients/jinja.py
yield token

return jinja2.sandbox.SandboxedEnvironment(
extensions=[MacroContextCatcherExtension])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so. cool.

@drewbanin
Copy link
Contributor

@cmcarthur this should also check if this, ref, target, etc are passed in as args, right? There shouldn't be a compiler error if this is passed in as an arg!

@cmcarthur
Copy link
Member Author

@drewbanin yep, that's right. anything passed in as an arg can be removed from the disallowed lists

@cmcarthur
Copy link
Member Author

merged into #356

@cmcarthur cmcarthur closed this Apr 3, 2017
@cmcarthur cmcarthur deleted the contextless-macros branch April 3, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcarthur @drewbanin