Add timing and thread info to sources.json artifact #3894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3804
Description
This PR adds the following fields to the
sources.json
artifact:Big question here is: is this the right change to make, or should we pursue moving this information into the
run_results.json
file instead? I think that adding it tosources.json
is a net-positive, it isn't a breaking change, and it doesn't preclude us from migrating this metadata into therun_results.json
file in the future.... so why not? :)Small question: if we did want to merge this, where should it live in the changelog?
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.