Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing and thread info to sources.json artifact #3894

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Sep 16, 2021

resolves #3804

Description

This PR adds the following fields to the sources.json artifact:

  • timing (same format as run_results.json)
  • execution_time
  • thread_id

Big question here is: is this the right change to make, or should we pursue moving this information into the run_results.json file instead? I think that adding it to sources.json is a net-positive, it isn't a breaking change, and it doesn't preclude us from migrating this metadata into the run_results.json file in the future.... so why not? :)

Small question: if we did want to merge this, where should it live in the changelog?

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 16, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can respond to the substantive point over in #3804 (comment). In the meantime, this feels like an uncontroversial improvement. Happy to get it in & under the wire for v0.21.0! We'll just want to bump the schema version for sources.json in v0.21.

Logistically speaking, you can just merge to develop once the tests pass. We're planning to merge develop into 0.21.latest ahead of cutting v0.21.0-rc1.

@drewbanin
Copy link
Contributor Author

Right on! I just updated the changelog and put this in for 0.21.0 and will merge when all is green :)

@drewbanin drewbanin merged commit 4b5b169 into develop Sep 16, 2021
@drewbanin drewbanin deleted the feature/source-freshness-timing-in-artifacts branch September 16, 2021 18:59
@jtcohen6 jtcohen6 mentioned this pull request Sep 23, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results in sources.json missing contextual info present in run_results.json
2 participants