[#4337] Always create an invocation_id, even when not tracking #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
suggested changes
Nov 24, 2021
There was a problem hiding this comment.
This looks great! The last step to get it into the json log messages would be to add invocation_id: e.get_invocation_id() to this dict
gshank
force-pushed
the
4337_always_invocation_id
branch
from
6a3ddfb
to
02d9952
Compare
gshank
force-pushed
the
4337_always_invocation_id
branch
from
02d9952
to
12edfc2
Compare
nathaniel-may
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4337
Description
For logging purposes we always want an invocation_id, even when we're not tracking. This pull request decouples the invocation_id from dbt.tracking.active_user.
I've added a 'get_invocation_id' class method to the base Event class, but I put the generic 'get_invocation_id' and the global variable invocation_id in dbt.events.functions, because that felt more appropriate and I don't think we want to import the base_types file everywhere that we're setting the invocation_id. That meant that I had to do the import of get_invocation_id in the Event.get_invocation_id function to avoid circular imports. Let me know if you see a better way of doing that.
Checklist
CHANGELOG.mdand added information about my change