loglines are not always created by events #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added a commit
that referenced
this pull request
Dec 2, 2021
* Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
jtcohen6
added a commit
that referenced
this pull request
Dec 2, 2021
* Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
jtcohen6
added a commit
that referenced
this pull request
Dec 2, 2021
* Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
* A few final logging touch-ups (#4388) * Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com> * Rollover + backup for dbt.log (#4405) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com> automatic commit by git-black, original commits: 8bdaa69 b90ab74
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Rm unused events, per #4104 * More structured ConcurrencyLine * Replace \n prefixes with EmptyLine * Reimplement ui.warning_tag to centralize logic * Use warning_tag for deprecations too * Rm more unused event types * Exclude EmptyLine from json logs * loglines are not always created by events (#4406) Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com> automatic commit by git-black, original commits: b90ab74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does some plumbing of optionals so mypy can help us realize we don't always convert events to strings. Namely
EmptyLine.Checklist
CHANGELOG.mdand added information about my change