user configurable event buffer size #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iknox-fa
commented
Dec 2, 2021
| # if and only if the event history deque will be completely filled by this event | ||
| # fire warning that old events are now being dropped | ||
| global EVENT_HISTORY | ||
| if len(EVENT_HISTORY) == ((EVENT_HISTORY.maxlen or 100000) - 1): | ||
| if len(EVENT_HISTORY) == (flags.EVENT_BUFFER_SIZE - 1): |
There was a problem hiding this comment.
@nathaniel-may Sorry I missed this in the first PR feedback, but this pattern is required or fire_event(EventBufferFull()) will create a recursion loop. :|
| @@ -88,25 +89,29 @@ def test_event_codes(self): | |||
|
|
|||
| class TestEventBuffer(TestCase): | |||
|
|
|||
| def setUp(self) -> None: | |||
| flags.EVENT_BUFFER_SIZE = 10 | |||
|
@nathaniel-may @jtcohen6 -- Is there anything else additional I need to do to document the new flag? I'm not sure of the SOP for new ones. |
|
good question. I'm not sure. Maybe @leahwicz knows? |
|
I'm not sure but let's merge this PR and we can always open another PR for docs |
|
|
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
4 tasks
leahwicz
added a commit
that referenced
this pull request
Dec 2, 2021
2 tasks
iknox-fa
added a commit
that referenced
this pull request
Feb 8, 2022
automatic commit by git-black, original commits: 2cd1f7d
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # No ticket-- follow on to #4358
Description
Add new global cli flag
EVENT_BUFFER_SIZEto control the number of events buffered in memory during operation.Checklist
CHANGELOG.mdand added information about my change