enable new columns in snapshots for adapters w/o bool types #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataders
force-pushed
the
newcols_snapshot_non-bool
branch
from
3f5be9a to
65a6884
Compare
dataders
changed the title
|
@jtcohen6 whenever you have a moment |
jtcohen6
added
the
Team:Adapters
4 tasks
|
closing this PR for #4871 so we can get your changes in for next release thank you so much for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4488
Description
creates a new macro
get_true_sql(), that can be dispatched so as to avoid the issue described in #4488Checklist
CHANGELOG.mdand added information about my change