fix git command for dep which points to a tag #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
changed the title
cmcarthur
requested changes
Jul 6, 2017
dbt/clients/git.py
Outdated
| else: | ||
| spec = 'origin/{}'.format(branch) | ||
|
|
||
| run_cmd(cwd, ['git', 'reset', '--hard', spec]) |
There was a problem hiding this comment.
can you also check the output of this and fail if this fails?
There was a problem hiding this comment.
@cmcarthur good idea!
dbt/clients/git.py
Outdated
| def list_tags(cwd): | ||
| out, err = run_cmd(cwd, ['git', 'tag', '--list']) | ||
| tags = set(out.decode('utf-8').strip().split("\n")) | ||
| return tags |
cmcarthur
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, dbt would silently use
origin/masterif you tried to specify a tag for a package. This happened becauseremote_branchwas set toorigin/{tag-name}, which is not the correct syntax forgit reseton a tag.Instead, we want to use
git reset --hard tags/{tag-name}.Fixes #463