Remove unneeded code in default snapshot materialization #4993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4742
Not just unneeded, also incorrect!
Description
See #4742 (comment) for the archaeology
tl;dr:
create_schema
a long time ago (Dec 2017), back when snapshots were archives defined indbt_project.yml
snapshot
task, just like for models in therun
taskcreate_schema
from the snapshot materialization. We even tweaked it to fix unexpected behavior, when the real fix would have been to remove it entirelyTesting
This is already covered by
test_cross_schema_snapshot
, which would fail if dbt did not first create{test_schema}_snapshotted
while running thesnapshot
task.Checklist