Bumping manifest schema to v5 #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
stu-k
approved these changes
Apr 12, 2022
jtcohen6
approved these changes
Apr 12, 2022
| @@ -1819,7 +1819,7 @@ def verify_manifest(self, expected_manifest): | |||
| elif key == 'metadata': | |||
| metadata = manifest['metadata'] | |||
| self.verify_metadata( | |||
| metadata, 'https://schemas.getdbt.com/dbt/manifest/v4.json') | |||
| metadata, 'https://schemas.getdbt.com/dbt/manifest/v5.json') | |||
There was a problem hiding this comment.
FYI until we migrate 029_docs_generate_tests to use the new framework, move it into the "adapter zone," and inherit/use it within our adapter plugins, this will cause test failures in our plugin repos:
- https://github.com/dbt-labs/dbt-redshift/blob/main/tests/integration/docs_generate_tests/test_docs_generate.py
- https://github.com/dbt-labs/dbt-snowflake/blob/main/tests/integration/docs_generate_tests/test_docs_generate.py
- https://github.com/dbt-labs/dbt-bigquery/blob/main/tests/integration/docs_generate_tests/test_docs_generate.py
There was a problem hiding this comment.
I'll work on converting those tests today.
VersusFacit
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Bumping manifest schema to v5 * Adding changelog
1 task
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* Bumping manifest schema to v5 * Adding changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping manifest schema for the v1.1 release
Corresponding schema change: dbt-labs/schemas.getdbt.com#12
Checklist