move deprecation check outside package caching #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
requested review from
leahwicz and
gshank
and removed request for
a team,
ChenyuLInx and
stu-k
emmyoop
added a commit
that referenced
this pull request
Apr 25, 2022
* move deprecation check outside package caching * add changelog
Merged
emmyoop
added a commit
that referenced
this pull request
Apr 25, 2022
* move deprecation check outside package caching (#5069) * move deprecation check outside package caching * add changelog * fix retry logic failures (#5137) * fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file * move unit test to old framework since new one doesn't exist here
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* move deprecation check outside package caching * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5068
Description
Check deprecation of packages outside of package caching. This is not actually causing error today. However, the deprecation doesn't get cached so it should live outside that logic. It's also preventing tests from working as expected so a real fix here allows for better tests.
Checklist