Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting scaffold and create_adater_plugin.py file from scripts section of core as they a… #5117

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Apr 20, 2022

resolves #

Description

deleting directory and a .py file from core as they are either deprecated or will live outside of core

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

…re either deprecated or will live outside of core
@cla-bot cla-bot bot added the cla:yes label Apr 20, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@McKnight-42 McKnight-42 self-assigned this May 4, 2022
@leahwicz
Copy link
Contributor

leahwicz commented May 9, 2022

@McKnight-42 is this in draft waiting on other PRs to be reviewed first or are we ready to go here with this PR?

@McKnight-42
Copy link
Contributor Author

@leahwicz I have it in draft cause we still have some Docs related PRs still up and i figured would be best to have everything as ready to go at once as we can

@McKnight-42 McKnight-42 marked this pull request as ready for review June 7, 2022 15:57
@McKnight-42 McKnight-42 requested a review from a team as a code owner June 7, 2022 15:57
@nathaniel-may
Copy link
Contributor

@McKnight-42 do we want to delete entirely or leave the script with just a comment and print statement that points to the new repo?

@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Jun 16, 2022

@nathaniel-may that's a good question, I know we were wanting to make it clear that we didn't want to use the .py file anymore and we link the new scaffold in the changelog, and will have it be whats referenced and pointed to in the docs. but if we feel changing out the file and still having it as a pointer I could be behind that implementation. any thoughts @jtcohen6 @dataders?

I pushed up a possible example.

…nt statement and leave comment that also points to the new scaffold
@McKnight-42 McKnight-42 merged commit f8d347e into main Jun 16, 2022
@McKnight-42 McKnight-42 deleted the mcknight/remove_create_adapter_plugin.py branch June 16, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants