Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mashumaro from 2.9 to 3.0.3 in /core #5118

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 20, 2022

resolves #4940

Description

This creates new third-party-stubs/mashumaro and adjusted those files to pass mypy.

It has a bug in doing to_msgpack():

/Users/gerda/FTA/dbt/core/dbt/parser/manifest.py:549: in write_manifest_for_partial_parse
    manifest_msgpack = self.manifest.to_msgpack()
/Users/gerda/FTA/dbt/env/lib/python3.8/site-packages/mashumaro/mixins/msgpack.py:44: in to_msgpack
    self.to_dict(**dict(**to_dict_kwargs))
<string>:24: in to_dict
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

.0 = <dict_itemiterator object at 0x108f2e720>

>   ???
E   TypeError: to_dict() got an unexpected keyword argument 'dialect'

<string>:24: TypeError

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@gshank gshank requested review from a team as code owners April 20, 2022 19:12
@gshank gshank requested review from emmyoop and VersusFacit April 20, 2022 19:12
@cla-bot cla-bot bot added the cla:yes label Apr 20, 2022
@gshank gshank marked this pull request as draft April 20, 2022 19:12
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank force-pushed the ct-413-bump_mashumaro branch from 2603a5b to 088a908 Compare July 12, 2022 16:12
@leahwicz
Copy link
Contributor

@gshank Ian made some progress in this PR #5336 on getting this to work and showed where he got stuck

@gshank gshank changed the title Bump mashumaro from 2.9 to 3.0.1 in /core Bump mashumaro from 2.9 to 3.0.3 in /core Jul 20, 2022
@gshank
Copy link
Contributor Author

gshank commented Jul 20, 2022

The bug in mashumaro has been fixed, so we are now upgrading to 3.0.3.

@gshank gshank marked this pull request as ready for review July 20, 2022 16:28
@gshank gshank requested a review from leahwicz July 20, 2022 16:29
@gshank gshank merged commit 5686cab into main Jul 20, 2022
@gshank gshank deleted the ct-413-bump_mashumaro branch July 20, 2022 21:15
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-413] Update Mashumaro to 3.0
2 participants