seed: Add new macro get_csv_sql #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of this new macro `get_csv_sql` comes as a suggestion by @jtcohen6 at dbt-labs/dbt-snowflake#112 (comment). The underlying reason is that the `dbt-snowflake` package needs to run these queries inside a transaction, but with the current implementation, the fix would require to duplicate the entire default seed materialization logic in the package.
adamantike
force-pushed
the
seed-new-macro-get_csv_sql
branch
from
a5f04d4
to
0a6f00b
Compare
|
@adamantike Thanks for opening! I've since realized that I missed an important nuance of the seed materialization in my initial comment over in dbt-labs/dbt-snowflake#112. I'll leave a new comment over there with the update. |
iknox-fa
approved these changes
May 3, 2022
|
@jtcohen6 I'm not sure I follow the adapters issue here, but the macro part looks sane to me so I'm giving it a 👍, but also adding you as a reviewer to ensure it meets the needs of the adapters ticket. |
|
@iknox-fa The change here is totally fine. It just won't actually address the root cause of the original issue (dbt-labs/dbt-snowflake#112). |
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
new macro `get_csv_sql`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation of this new macro
get_csv_sqlcomes as a suggestion by @jtcohen6 at dbt-labs/dbt-snowflake#112 (comment).The underlying reason is that the
dbt-snowflakepackage needs to run these queries inside a transaction, but with the current implementation, the fix would require to duplicate the entire default seed materialization logic in the package.Resolves #5206
Checklist
changie newto create a changelog entry