Fix postgres handling for unlimited varchars #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
the
Team:Adapters
jtcohen6
added
the
ready_for_review
|
Close/reopen to retrigger snyk |
emmyoop
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Looks good but I'm going to let @McKnight-42 have the final approval.
McKnight-42
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
@shrodingers Sorry for how long it's taken to get eyes on this, seems like a super reasonable! great conversation in the issue between you and @jtcohen6 just the minor fix @emmyoop pointed out for changelog and this should be good to merge!
Co-authored-by: Emily Rockman <ebuschang@gmail.com>
|
Thanks @emmyoop, @McKnight-42 and @jtcohen6 ! |
emmyoop
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Looks good to me. Thanks for pulling in the requested changes @shrodingers!
|
@shrodingers great work on this! |
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
* Fix postgres handling for unlimited varchars * fix: correctly name varchar * chore: added changelog entry * Update .changes/unreleased/Fixes-20220523-103843.yaml Co-authored-by: Emily Rockman <ebuschang@gmail.com> Co-authored-by: Emily Rockman <ebuschang@gmail.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Fix postgres handling for unlimited varchars * fix: correctly name varchar * chore: added changelog entry * Update .changes/unreleased/Fixes-20220523-103843.yaml Co-authored-by: Emily Rockman <ebuschang@gmail.com> Co-authored-by: Emily Rockman <ebuschang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5238
Description
Handles
varcharthe same way astextfor postgres columns (since unlimitedvarcharon postgres is not implicitely limited to 256 characters as on redshift)Checklist
changie newto create a changelog entry