remove CTEs for schema tests

CHANGELOG.md

@@ -1,3 +1,14 @@
+## dbt 0.9.0 (unreleased)
+
+### Improvements
+
+- Replace schema test CTEs with subqueries to speed them up for Postgres ([#536](https://github.com/fishtown-analytics/dbt/pull/536))
+
+### New Contributors
+
+- @ronnyli
+ - https://github.com/fishtown-analytics/dbt/pull/536
+
 ## dbt 0.9.0 Alpha 2 (September 20, 2017)
 
 ### Overview

dbt/include/global_project/macros/schema_tests/not_null.sql

@@ -1,18 +1,9 @@
 
 {% macro test_not_null(model, arg) %}
 
-with validation as (
-
- select
- {{ arg }} as not_null_field
-
- from {{ model }}
-
-)
-
 select count(*)
-from validation
-where not_null_field is null
+from {{ model }}
+where {{ arg }} is null
 
 {% endmacro %}
 

dbt/include/global_project/macros/schema_tests/relationships.sql

@@ -1,27 +1,18 @@
 
 {% macro test_relationships(model, field, to, from) %}
 
-with parent as (
 
- select
- {{ field }} as id
-
- from {{ to }}
-
-),
-
-child as (
+select count(*)
+from (
 
  select
  {{ from }} as id
 
  from {{ model }}
+ where {{ from }} is not null
+ and {{ from }} not in (select {{ field }}
+ from {{ to }})
 
-)
-
-select count(*)
-from child
-where id is not null
- and id not in (select id from parent)
+) validation_errors
 
 {% endmacro %}

dbt/include/global_project/macros/schema_tests/unique.sql

@@ -1,28 +1,17 @@
 
 {% macro test_unique(model, arg) %}
 
-with validation as (
+select count(*)
+from (
 
  select
- {{ arg }} as unique_field
+ {{ arg }}
 
  from {{ model }}
  where {{ arg }} is not null
-
-),
-
-validation_errors as (
-
- select
- unique_field
-
- from validation
- group by unique_field
+ group by {{ arg }}
  having count(*) > 1
 
-)
-
-select count(*)
-from validation_errors
+) validation_errors
 
 {% endmacro %}