Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/fix quotes behaviour in snapshots #5389

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Fix/fix quotes behaviour in snapshots #5389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a827a9
fix: add quotes to relation
pquadri Jun 17, 2022
a8ba96d
fix: add quotes correctly
pquadri Jun 17, 2022
b16252e
chore: reset main.py
pquadri Jun 17, 2022
8b6ef6a
chore: reset main.py from master
pquadri Jun 17, 2022
2a16de5
chore: newline
pquadri Jun 17, 2022
abeddc5
chore: changie
pquadri Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20220617-114443.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Properly use quotes for Snowflake snapshots when checking all columns
time: 2022-06-17T11:44:43.978834+02:00
custom:
Author: pquadri
Issue: "2975"
PR: "5389"
2 changes: 1 addition & 1 deletion core/dbt/include/global_project/macros/materializations/snapshots/strategies.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
{%- set intersection = [] -%}
{%- for col in query_columns -%}
{%- if col in existing_cols -%}
{%- do intersection.append(col) -%}
{%- do intersection.append(adapter.quote(col)) -%}
{%- else -%}
{% set ns.column_added = true %}
{%- endif -%}
Expand Down