Fix handling of top-level exceptions #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
jtcohen6
reviewed
Jul 26, 2022
| @@ -142,7 +142,6 @@ def main(args=None): | |||
| exit_code = e.code | |||
|
|
|||
| except BaseException as e: | |||
| traceback.print_exc() | |||
There was a problem hiding this comment.
Given that this was an incidental inclusion in v1.2.0, I'd also be in favor of a PR that removed this line alone, and backporting that PR to 1.2.latest for inclusion in a v1.2.1 patch release
There was a problem hiding this comment.
I'm actually looking at two different problems, really, the lack of a stack trace for top level exceptions and catching exceptions in threads. I could make the current code the "lack of a stack trace" fix and backport it?
ChenyuLInx
approved these changes
Jul 28, 2022
gshank
added
the
backport 1.2.latest
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
(cherry picked from commit b43fc76)
gshank
added a commit
that referenced
this pull request
Jul 28, 2022
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5564
Description
Errors that were caught as BaseExceptions in the main function were not displaying or storing the stack trace because it was flagged as debug level and also flagged as not to be written to the file. I have removed the "NoFile" flag from the events that handle top level exceptions and left it only for integration tests and "clean" command events.
A different pr will be used to address catching exception in threads.
Checklist
changie newto create a changelog entry