Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] #5627 to 1.2.latest #5640

Merged
merged 1 commit into from
Aug 10, 2022
Merged

[Backport] #5627 to 1.2.latest #5640

merged 1 commit into from
Aug 10, 2022

Conversation

jtcohen6
Copy link
Contributor

I think the automated backport action does not work with PRs from forks: https://github.com/dbt-labs/dbt-core/actions/runs/2834765275

@varun-dc @jtcohen6
Use sys.exit instead of exit (#5627)
9a440bc 
* Use sys.exit instead of exit

* Add changelog
@jtcohen6 jtcohen6 requested a review from a team August 10, 2022 18:15
@jtcohen6 jtcohen6 requested a review from a team as a code owner August 10, 2022 18:15
@jtcohen6 jtcohen6 requested review from stu-k and McKnight-42 August 10, 2022 18:15
@cla-bot cla-bot bot added the cla:yes label Aug 10, 2022
@jtcohen6 jtcohen6 changed the title [Backport] #5627 to 12latest [Backport] #5627 to 1.2.latest Aug 10, 2022
@emmyoop
Copy link
Member

emmyoop commented Aug 10, 2022

Aw, you're right. It's running in the context of the fork so the token does not have permission to commit directly to a branch in dbt-labs. it has read only permission:

GITHUB_TOKEN Permissions
  Contents: read
  Metadata: read
  PullRequests: read

Not a blocker but I'll create a tech debt ticket to see if we can fix this.

emmyoop
emmyoop approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jtcohen6 jtcohen6 merged commit 39901c5 into 1.2.latest Aug 10, 2022
@jtcohen6 jtcohen6 deleted the backport/5627-to-12latest branch August 10, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@stu-k stu-k Awaiting requested review from stu-k

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtcohen6 @emmyoop @varun-dc