Add supported languages to materializations #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
reviewed
Aug 22, 2022
core/dbt/clients/jinja.py
Outdated
|
|
||
|
|
||
| def get_supported_languages(node: jinja2.nodes.Macro) -> List[ModelLanguage]: | ||
| no_args = not node.args or not node.defaults |
There was a problem hiding this comment.
I am assuming the length of args is always gonna be longer than defaults(contain both args and kwargs)? So node.defaults doesn't need to be checked here?
core/dbt/clients/jinja.py
Outdated
|
|
||
| def get_supported_languages(node: jinja2.nodes.Macro) -> List[ModelLanguage]: | ||
| no_args = not node.args or not node.defaults | ||
| dif_args_and_defaults = len(node.args) != len(node.defaults) |
There was a problem hiding this comment.
This could be causing issue if we decided to add an arg to materialization Macro in the future. Since kwargs are always going to be after args, we can use the index to end to get things.
node.args = ["arg1", "supported_language", "another_key_for_kwarg"]
node.defaults = [['sql'], {"something_else": 1}]
you can get supported language by node.defaults[-(len(node.args) - lang_idx)]
…cro, update schema
|
|
This was referenced Aug 25, 2022
Closed
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
* Add supported languages to materializations * Add changie entry * Linting * add more error and only get supported language for materialization macro, update schema * fix test and add more check Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Add supported languages to materializations * Add changie entry * Linting * add more error and only get supported language for materialization macro, update schema * fix test and add more check Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* Add supported languages to materializations * Add changie entry * Linting * add more error and only get supported language for materialization macro, update schema * fix test and add more check Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5569
Description
Adds support for materializations to have supported languages. If not set, this default to
sql.Checklist
changie newto create a changelog entry