-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to current working directory for profiles.yml
and fall back to ~/.dbt
#5717
Conversation
…g up profiles directory
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
@dbeatty10 Everything here makes sense to me! One point of clarification, and responses to your questions. "Look here first" - which "here"?
As discussed during our meeting on Wednesday, this should just be the current working directory. In 95% of cases, we should expect the current working directory == the directory of the active root project (
Questions
Seems sufficient to me!
I don't think so. The Lines 15 to 18 in f5a94fc
dbt Cloud uses the Help textI realized our CLI help text for We have an old + new CLI now :) Lines 261 to 264 in f5a94fc
dbt-core/core/dbt/cli/params.py Line 164 in f5a94fc
|
Okay, I've made all those updates @jtcohen6:
|
Ready to rock & roll, whether here or there |
profiles.yml
and fall back to ~/.dbt
this is gonna make quickstart guides so much easier! |
@dbeatty10 does that change anything to this doc #5425? Sorry I owe you a review here... |
@leahwicz I'll double check if that ADR needs any changes. This PR does implement this exactly: However, we did not implement anything in relation to the non-existent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could merge main to handle the merge conflicts message, this looks good to me!
@gshank merge conflicts handled now 👍 |
resolves #5411
uses #5715
Description
Use the following priority order to search for the
profiles.yml
configuration file:--profiles-dir
command-line argumentDBT_PROFILES_DIR
environment variable~/.dbt/
)Checklist
profiles.yml
and fall back to~/.dbt
docs.getdbt.com#2024changie new
to create a changelog entryOutstanding questions
dbt debug
produces the correct output; how many other subcommands do we need to test?core/dbt/lib.py
handles this new case properly? If so, then how?Some non-critical curiosities while we're here:
dbt-core/core/dbt/task/debug.py
Lines 24 to 26 in 49e7bdb
dbt.config.profile.DEFAULT_PROFILES_DIR
be replaced withdbt.flags.DEFAULT_PROFILES_DIR
?dbt-core/core/dbt/flags.py
Line 13 in 49e7bdb
dbt-core/core/dbt/config/profile.py
Line 26 in 49e7bdb
dbt-core/core/dbt/config/profile.py
Line 47 in 49e7bdb
dbt-core/core/dbt/main.py
Line 45 in 49e7bdb
dbt-core/test/unit/test_flags.py
Line 8 in 49e7bdb