Allow for more complex version comparison #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for letters in version names Add tests for version info
|
Let's try to combine this PR with the version comparison code over here: #542 cc @cmcarthur |
|
hey @mturzanska - we've been bad about getting these PRs merged, but I'm going to have some time to dig in this week. Do you mind if I try to take this over the line? |
|
@drewbanin sure, go ahead |
|
Closing this in favor of #797 Thanks for your help here @mturzanska -- I'll be sure to give you credit for this one in the release notes :) |
drewbanin
added a commit
that referenced
this pull request
Jun 27, 2018
* Allow for more complex version comparison Allow for letters in version names Add tests for version info * Fix integration tests * Combine code from @mturzanska's PR with development Based on: #577 Fixes: #557
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Allow for more complex version comparison Allow for letters in version names Add tests for version info * Fix integration tests * Combine code from @mturzanska's PR with development Based on: #577 Fixes: #557 automatic commit by git-black, original commits: d28407d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for letters in version names
Add tests for version info
Addresses #557