Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings as errors during tests #5800

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix warnings as errors during tests #5800

merged 2 commits into from
Sep 9, 2022

Conversation

stu-k
Copy link
Contributor

@stu-k stu-k commented Sep 9, 2022

resolves #5424

Description

Added check for warning and a new RunResultWarningMessage event.

Checklist

Added RunResultWarningMessage event to support this change.
@cla-bot cla-bot bot added the cla:yes label Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@stu-k stu-k marked this pull request as ready for review September 9, 2022 15:15
@stu-k stu-k requested a review from a team September 9, 2022 15:15
@stu-k stu-k requested review from a team as code owners September 9, 2022 15:15
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stu-k stu-k merged commit 79da002 into main Sep 9, 2022
@stu-k stu-k deleted the CT-792/fix-warn-as-error branch September 9, 2022 17:50
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
Added RunResultWarningMessage event to support this change.
@ChristianP89
Copy link

ChristianP89 commented Nov 22, 2022

Came from #5424
@stu-k thanks for fixing this :)

Noob question: How can I see in what version this will be released (or if it has already been released with dbt 1.3)?
Thanks

Update: Never mind, found it in the Changelog under 1.3. Thanks
https://github.com/dbt-labs/dbt-core/blob/1.3.latest/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-792] [Bug] Warnings are being logged as errors during dbt test
3 participants