Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding expression validation and renaming function #5872

Closed

Conversation

callum-mcdata
Copy link
Contributor

resolves #5871

Description

  • Changes the default value of the expression/sql field to be None instead of ""
  • Adding test to confirm this behavior

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Sep 16, 2022
@callum-mcdata callum-mcdata deleted the adding_expression_validation_and_renaming_function branch January 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1201] [Bug] Metrics don't require expression field
2 participants