Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling and Adapter management work with Click #5892

Merged
merged 27 commits into from
Sep 21, 2022

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Sep 20, 2022

resolves #5531
resolves #5533

Description

Adds Profiling and Adapter management to Click CLI

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 20, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@@ -1,23 +1,17 @@
import threading
from pathlib import Path
from contextlib import contextmanager
Copy link
Contributor Author

@iknox-fa iknox-fa Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only new import. All of the rest of the changes are from using isort to correctly sort the imports which wasn't done before.

#leaveitbetter

@iknox-fa iknox-fa changed the title Iknox/ct 907 profiling works with click Profiling and Adapter management work with Click Sep 20, 2022
@iknox-fa iknox-fa marked this pull request as ready for review September 20, 2022 19:49
@iknox-fa iknox-fa requested review from a team as code owners September 20, 2022 19:49
@iknox-fa iknox-fa requested review from VersusFacit, McKnight-42, stu-k, jtcohen6 and ChenyuLInx and removed request for a team, VersusFacit and McKnight-42 September 20, 2022 19:49
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out 👍

@iknox-fa iknox-fa merged commit fd778dc into main Sep 21, 2022
@iknox-fa iknox-fa deleted the iknox/CT-907-profiling-works-with-click branch September 21, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-909] Adapter Management works with Click [CT-907] Profiling works with Click
2 participants