Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT 815 partial parsing handling of deleted metrics #5920

Merged
merged 3 commits into from
Sep 23, 2022
Merged

CT 815 partial parsing handling of deleted metrics #5920

merged 3 commits into from
Sep 23, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 23, 2022

resolves #5444

Description

Schedule nodes referencing a deleted metric for parsing.

Checklist

@gshank gshank requested review from a team as code owners September 23, 2022 17:37
@cla-bot cla-bot bot added the cla:yes label Sep 23, 2022
@gshank gshank requested a review from emmyoop September 23, 2022 19:11
emmyoop
emmyoop approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I do hate that the old tests are being modified but they're a lot and I agree it's out of scope to convert them here. These might be the next set of tests I try to convert - would be nice for them to live in the new tests.

@gshank gshank merged commit 5328a64 into main Sep 23, 2022
@gshank gshank deleted the ct-815_pp_deleted_metrics branch September 23, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@peterallenwebb peterallenwebb Awaiting requested review from peterallenwebb peterallenwebb is a code owner automatically assigned from dbt-labs/core-team

@lostmygithubaccount lostmygithubaccount Awaiting requested review from lostmygithubaccount lostmygithubaccount was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-815] Partial parsing error at execution for metric modification
2 participants
@gshank @emmyoop