-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for Koalas DataFrames #5928
Conversation
@@ -57,6 +57,25 @@ def model(dbt, session): | |||
return df | |||
""" | |||
|
|||
KOALAS_MODEL = """ | |||
import databricks.koalas as ks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbeatty10 Seems like this is only for databricks, I would put this one as a separate test in dbt-spark
, maybe somewhere here? Just as a new test class should be good enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that Koalas DataFrames can also be used on BigQuery even though the package is published by Databricks.
I did manual testing of Koalas on BigQuery here:
dbt-labs/dbt-bigquery#321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Koalas is a separate package from Spark and should be installed in the target cluster to pass this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolves #5927
Continuing work merged in #5906
Description
Test case for Koalas DataFrames (the predecessor to pandas-on-Spark DataFrames AKA pandas API DataFrames).
Group of related pull requests
Checklist
I have opened an issue to add/update docs, ordocs changes are not required/relevant for this PRI have runchangie new
to create a changelog entry