Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check length of args of python model function before accessing it #6042

Merged
merged 3 commits into from
Oct 11, 2022
Merged

fix: check length of args of python model function before accessing it #6042

merged 3 commits into from
Oct 11, 2022

Conversation

chamini2
Copy link
Contributor

@chamini2 chamini2 commented Oct 10, 2022 •
edited
Loading

resolves #6041

Description

Check the number of arguments in the python model being parsed before checking if the first one is a variable named dbt

Checklist

@cla-bot cla-bot bot added the cla:yes label Oct 10, 2022
@dbeatty10 dbeatty10 mentioned this pull request Oct 10, 2022
Closed
2 tasks
@leahwicz leahwicz requested a review from ChenyuLInx October 11, 2022 13:37
ChenyuLInx
ChenyuLInx approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @chamini2 Thanks for the quick patch! There are some unit tests here, do you mind add one for this case? And maybe a change log

@chamini2 chamini2 marked this pull request as ready for review October 11, 2022 20:08
@chamini2 chamini2 requested review from a team as code owners October 11, 2022 20:08
@chamini2 chamini2 requested a review from emmyoop October 11, 2022 20:08
@ChenyuLInx ChenyuLInx merged commit dcd6ef7 into dbt-labs:main Oct 11, 2022
@ChenyuLInx
Copy link
Contributor

@chamini2 Thanks for catching this and fix it!

ChenyuLInx pushed a commit that referenced this pull request Oct 11, 2022
@chamini2 @ChenyuLInx
fix: check length of args of python model function before accessing it (
34c2cdc 
#6042)

* fix: check length of args of python model function before accessing it

* Add test

* changie

(cherry picked from commit dcd6ef7)
@ChenyuLInx ChenyuLInx mentioned this pull request Oct 11, 2022
Merged
6 tasks
leahwicz pushed a commit that referenced this pull request Oct 11, 2022
@ChenyuLInx @chamini2
fix: check length of args of python model function before accessing it (
65f40b3 
#6042) (#6049)

* fix: check length of args of python model function before accessing it

* Add test

* changie

(cherry picked from commit dcd6ef7)

Co-authored-by: Matteo Ferrando <matteo.ferrando2@gmail.com>
@chamini2 chamini2 deleted the parse-model branch October 12, 2022 15:30
@aranke aranke mentioned this pull request Jul 19, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 left review comments

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
backport 1.3.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1326] [Bug] Python model with no arguments in the function raises index our of range exception
3 participants
@chamini2 @ChenyuLInx @dbeatty10