Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate 034 integration test to functional #6054

Merged
merged 4 commits into from
Oct 12, 2022
Merged

migrate 034 integration test to functional #6054

merged 4 commits into from
Oct 12, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #5831

Description

Checklist

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner October 12, 2022 17:44
@cla-bot cla-bot bot added the cla:yes label Oct 12, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt self-assigned this Oct 12, 2022
@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Oct 12, 2022
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner October 12, 2022 18:18
This was referenced Oct 12, 2022
Merged
Merged
Merged
McKnight-42
McKnight-42 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the _run_and_check this all looks. good to me!

McKnight-42
McKnight-42 reviewed Oct 12, 2022
View reviewed changes
tests/adapter/dbt/tests/adapter/relations/test_changing_relation_type.py
@pytest.fixture(scope="class")
def models(self):
return {
"model_mc_modelface.sql": _DEFAULT_CHANGE_RELATION_TYPE_MODEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun model name

@colin-rogers-dbt colin-rogers-dbt merged commit 0959979 into main Oct 12, 2022
@colin-rogers-dbt colin-rogers-dbt deleted the CT-1168 branch October 12, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-group

Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1168] 034_changing_relation_type_tests
2 participants
@colin-rogers-dbt @McKnight-42