convert 027 cycle test #6094
Merged
convert 027 cycle test #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
force-pushed
the
arky/ct-1365-027-cycle-tests
branch
from
2cc3f30
to
5b82a2c
Compare
MichelleArk
commented
Oct 19, 2022
| def models(self): | ||
| return "simple_cycle_models" | ||
|
|
||
| @property |
There was a problem hiding this comment.
Note: TestSimpleCycle.test_postgres_simple_cycle and TestComplexCycle.test_postgres_simple_cycle weren't previously detected as tests because of the @property decorator:
❯ python3 -m pytest -m profile_postgres test/integration/027_cycle_tests
============================================= test session starts ==============================================
platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/michelleark/src/dbt-core, configfile: pytest.ini
plugins: xdist-2.5.0, forked-1.4.0, csv-3.0.0, logbook-1.2.0, flaky-3.7.0, mock-3.10.0, dotenv-0.5.2, cov-4.0.0
collected 0 items
============================================ no tests ran in 0.98s =============================================Removing the decorator resulted in successful test runs locally though:
❯ python3 -m pytest -m profile_postgres test/integration/027_cycle_tests
============================================= test session starts ==============================================
platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/michelleark/src/dbt-core, configfile: pytest.ini
plugins: xdist-2.5.0, forked-1.4.0, csv-3.0.0, logbook-1.2.0, flaky-3.7.0, mock-3.10.0, dotenv-0.5.2, cov-4.0.0
collected 2 items
test/integration/027_cycle_tests/test_cycles.py .. [100%]
============================================== 2 passed in 2.00s ===============================================
stu-k
approved these changes
Oct 20, 2022
emmyoop
requested changes
Oct 20, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6093
Description
Checklist
changie newto create a changelog entry