Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests per Colin's idea #6095

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add unit tests per Colin's idea #6095

merged 1 commit into from
Oct 20, 2022

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Oct 18, 2022 •
edited
Loading

Description

Add unit tests for recent stringifier functors added to events library.

@colin-rogers-dbt raised the possibility of this for #5874 and after considering it, I figured, hey, we might as well.

The tests added will fail unless the so-called Functor classes that have __post_init__s are included.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Oct 18, 2022
@VersusFacit VersusFacit requested a review from a team as a code owner October 18, 2022 19:53
@cla-bot cla-bot bot added the cla:yes label Oct 18, 2022
@VersusFacit VersusFacit requested review from colin-rogers-dbt and removed request for iknox-fa October 18, 2022 19:54
colin-rogers-dbt
colin-rogers-dbt approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@VersusFacit VersusFacit force-pushed the mp/add_unit_tests_to_events branch from a622e76 to ae5b563 Compare October 20, 2022 05:11
@VersusFacit VersusFacit merged commit a7670a3 into main Oct 20, 2022
@VersusFacit VersusFacit deleted the mp/add_unit_tests_to_events branch October 20, 2022 05:52
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @colin-rogers-dbt