Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converting 023_exit_codes_tests #6105

Merged
merged 2 commits into from
Nov 1, 2022
Merged

converting 023_exit_codes_tests #6105

merged 2 commits into from
Nov 1, 2022

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Oct 19, 2022 •
edited
Loading

resolves #6100

Description

  • Converts 023_exit_codes integration test to pytest
  • Adds guidance on fixtures.py to CONVERTING.md - is there a better place for this?

Checklist

@cla-bot cla-bot bot added the cla:yes label Oct 19, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Oct 19, 2022
@MichelleArk MichelleArk force-pushed the arky/ct-1370-test-exit-codes branch from 43fc30b to 84c142f Compare October 19, 2022 19:31
@MichelleArk MichelleArk changed the title [WIP] converting 023_exit_codes_tests converting 023_exit_codes_tests Oct 20, 2022
@MichelleArk MichelleArk marked this pull request as ready for review October 20, 2022 20:15
@MichelleArk MichelleArk requested a review from a team as a code owner October 20, 2022 20:15
@MichelleArk MichelleArk merged commit a427484 into main Nov 1, 2022
@MichelleArk MichelleArk deleted the arky/ct-1370-test-exit-codes branch November 1, 2022 20:26
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-k stu-k stu-k approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1370] 023_exit_codes
2 participants
@MichelleArk @stu-k